Auto-detect git remote name instead of assuming 'origin'#2345
Closed
seefood wants to merge 1 commit intoBash-it:masterfrom
Closed
Auto-detect git remote name instead of assuming 'origin'#2345seefood wants to merge 1 commit intoBash-it:masterfrom
seefood wants to merge 1 commit intoBash-it:masterfrom
Conversation
Adds automatic detection of git remote name when BASH_IT_REMOTE is not set, fixing issues for users with non-standard remote names like 'me', 'upstream', 'fork', etc. **Problem:** Commands like `bash-it version`, `bash-it update`, and `bash-it doctor` hard-coded the remote name as "origin", causing failures when users have different remote naming conventions: ``` $ bash-it version error: No such remote 'origin' ``` **Solution:** Created `_bash-it-get-remote-name()` helper function that: 1. Returns BASH_IT_REMOTE if already set (preserves user override) 2. Auto-detects first available remote via `git remote | head -n 1` 3. Falls back to "origin" if no remotes found Updated three functions to use auto-detection: - `_bash-it-update-()` (lib/helpers.bash:254) - `_bash-it-version()` (lib/helpers.bash:370) - `_bash-it-doctor-summary()` (lib/helpers.bash:564) **Benefits:** - No configuration required for single-remote repos - Works with any remote name (me, fork, upstream, etc.) - Backward compatible: BASH_IT_REMOTE override still works - Fallback to "origin" maintains existing behavior for edge cases **Testing:** - Verified with non-standard remote name 'me' - Tested BASH_IT_REMOTE environment variable preservation - Shellcheck passes with no warnings Fixes Bash-it#2317 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
seefood
added a commit
that referenced
this pull request
Oct 7, 2025
Updated all three planning documents to reflect the completed work: **Issues Fixed (6 total)**: - #2317: Auto-detect git remote (PR #2345) - #2248: Laravel artisan completion (PR #2349) - #2296: down4me URL malformation (PR #2350) - #2260: SSH completion @ sign (PR #2351) - #2238: Uninstall script backup (PR #2352) - #2216: Node version conditional display (PR #2353) **Changes to docs/plans/**: 1. bash-it-issues-comprehensive-analysis.md - Marked 5 quick wins as FIXED with PR numbers - Updated executive summary: 32 → 27 open issues - Updated work plan to show Phase 1 completed - Updated issue reference appendix 2. bash-it-quick-reference.md - Moved completed issues to "Fixed" section - Updated TL;DR metrics - Removed completed items from decision list - Updated metrics table with current progress 3. bash-it-roadmap-2025.md - Updated health metrics (32 → 27 issues) - Marked Phase 1 as COMPLETED - Listed all 6 PRs with dates - Updated success criteria checkmarks **Remaining Work**: - 1 quick fix (#2314 - todo alias rename) - 18 stale issues to close - 4 strategic decisions needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automatic detection of git remote name when
BASH_IT_REMOTEis not set, fixing issues for users with non-standard remote names likeme,upstream,fork, etc.Problem
Commands like
bash-it version,bash-it update, andbash-it doctorhard-coded the remote name as "origin", causing failures when users have different remote naming conventions:$ bash-it version error: No such remote 'origin'Solution
Created
_bash-it-get-remote-name()helper function that:BASH_IT_REMOTEif already set (preserves user override)git remote | head -n 1Updated three functions to use auto-detection:
_bash-it-update-()(lib/helpers.bash:254)_bash-it-version()(lib/helpers.bash:370)_bash-it-doctor-summary()(lib/helpers.bash:564)Benefits
BASH_IT_REMOTEoverride still worksTesting
BASH_IT_REMOTEenvironment variable preservationFixes #2317
🤖 Generated with Claude Code